fix: running eslint on filenames containing spaces #1484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bcfe309 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Manually adding quotes to the filenames shouldn't be necessary, and hasn't worked crossplatform before... let's see what the tests say. EDIT: Looks like tests mostly work. |
iiroj
requested changes
Dec 10, 2024
f8d9bbe to
bcfe309
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execution of eslint using lint-staged fails when file path contains whitespaces and some workaround similar to those described in #773 is needed.
Example: For the file
/path/to/file with spaces.js, it fails with:ESlint debug print contains message like this:
However, the
execalibrary supports a simple space backlash escaping which can be leveraged here.