-
-
Notifications
You must be signed in to change notification settings - Fork 355
Bump dependencies from commit fa2686 #2913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
updates: - [github.com/psf/black-pre-commit-mirror: 23.12.0 → 23.12.1](psf/black-pre-commit-mirror@23.12.0...23.12.1) - [github.com/astral-sh/ruff-pre-commit: v0.1.8 → v0.1.9](astral-sh/ruff-pre-commit@v0.1.8...v0.1.9)
This is the autodeps run for #2912 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2913 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 115 115
Lines 17310 17310
Branches 3110 3110
=======================================
Hits 17251 17251
Misses 40 40
Partials 19 19
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, commentary
@@ -4,10 +4,6 @@ | |||
# | |||
# pip-compile test-requirements.in | |||
# | |||
aiohttp==3.9.1 | |||
# via black |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised that black used to require aiohttp!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was slightly concerned when I saw a bunch of dependencies no longer required and looked into it myself as well, and apparently something with hatchling had a bug somewhere and had extra dependencies counting towards default installation dependencies or something around those lines, and the new release of black resolves those issues. ("extra" dependencies I am referring to (they probably have a proper name but I have forgotten it) are that feature where you can specify your package like idlemypyextension[user]
instead of just idlemypyextension
and the [user] one will install more dependencies)
@@ -232,10 +232,11 @@ def returncode(self) -> int | None: | |||
async def __aenter__(self) -> Self: | |||
return self | |||
|
|||
# Type ignore is for `Type of decorated function contains type "Any" ("Callable[[Process], Coroutine[Any, Any, None]]")` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a mypy bug :'(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I thought so too, but I haven't made a bug report for it as of writing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it could be an issue in _deprecate.deprecate that didn't surface previously, but idk.
No description provided.