8000 Bump dependencies from commit fa2686 by github-actions[bot] · Pull Request #2913 · python-trio/trio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump dependencies from commit fa2686 #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 26, 2023
Merged

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

pre-commit-ci bot and others added 2 commits December 25, 2023 21:11
updates:
- [github.com/psf/black-pre-commit-mirror: 23.12.0 → 23.12.1](psf/black-pre-commit-mirror@23.12.0...23.12.1)
- [github.com/astral-sh/ruff-pre-commit: v0.1.8 → v0.1.9](astral-sh/ruff-pre-commit@v0.1.8...v0.1.9)
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 26, 2023
@github-actions github-actions bot enabled auto-merge (squash) December 26, 2023 02:26
@CoolCat467
Copy link
Member

This is the autodeps run for #2912

Copy link
codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (683f5cb) 99.65% compared to head (1349390) 99.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2913   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         115      115           
  Lines       17310    17310           
  Branches     3110     3110           
=======================================
  Hits        17251    17251           
  Misses         40       40           
  Partials       19       19           
Files C 8000 overage Δ
src/trio/_subprocess.py 100.00% <100.00%> (ø)

@CoolCat467 CoolCat467 disabled auto-merge December 26, 2023 04:14
Copy link
Contributor
@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, commentary

@@ -4,10 +4,6 @@
#
# pip-compile test-requirements.in
#
aiohttp==3.9.1
# via black
Copy link
Contributor< 8000 /span>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised that black used to require aiohttp!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was slightly concerned when I saw a bunch of dependencies no longer required and looked into it myself as well, and apparently something with hatchling had a bug somewhere and had extra dependencies counting towards default installation dependencies or something around those lines, and the new release of black resolves those issues. ("extra" dependencies I am referring to (they probably have a proper name but I have forgotten it) are that feature where you can specify your package like idlemypyextension[user] instead of just idlemypyextension and the [user] one will install more dependencies)

@@ -232,10 +232,11 @@ def returncode(self) -> int | None:
async def __aenter__(self) -> Self:
return self

# Type ignore is for `Type of decorated function contains type "Any" ("Callable[[Process], Coroutine[Any, Any, None]]")`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a mypy bug :'(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I thought so too, but I haven't made a bug report for it as of writing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be an issue in _deprecate.deprecate that didn't surface previously, but idk.

@A5rocks A5rocks merged commit 7642383 into master Dec 26, 2023
@A5rocks A5rocks deleted the autodeps/bump_from_fa2686 branch December 26, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0