Make serde support more complete #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
approved these changes
Mar 6, 2024
bluss
reviewed
Mar 6, 2024
justinlovinger
suggested changes
Sep 10, 2024
|
@saona-raimundo could you please rebase on top of the latest |
Serialization of these enums is needed for users and it does not harm to add a serialization implementation here.
XVilka
requested changes
Dec 1, 2024
There was a problem hiding this comment.
Please fix compilation errors:
error[E0433]: failed to resolve: could not find `Serialize` in `serde`
--> src/lib.rs:178:47
|
178 | #[cfg_attr(feature = "serde-1", derive(serde::Serialize, serde::Deserialize))]
| ^^^^^^^^^ could not find `Serialize` in `serde`
|
note: found an item that was configured out
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde-1.0.215/src/lib.rs:343:37
|
343 | pub use serde_derive::{Deserialize, Serialize};
| ^^^^^^^^^
note: the item is gated behind the `serde_derive` feature
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde-1.0.215/src/lib.rs:341:7
|
341 | #[cfg(feature = "serde_derive")]
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
Sorry for the mistake, I forgot to check compilation using the serde feature. |
XVilka
approved these changes
Dec 23, 2024
daehiff
pushed a commit
to daehiff/petgraph
that referenced
this pull request
Dec 23, 2024
Related to petgraph#139 It adds serde support for small enums used as markers.
daehiff
pushed a commit
to daehiff/petgraph
that referenced
this pull request
Dec 23, 2024
Related to petgraph#139 It adds serde support for small enums used as markers.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #139
It adds serde support for small enums used as markers.