Do not leak directory info if append_index_html_on_directories = false #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If append_index_html_on_directories is false, no info about directories should be leaked. Before this commit, one could identify directories by checking for temporary redirects (like testcase redirect_to_trailing_slash_on_dir()). This commit prevents the redirect and directly returns 404 Not found instead.
jplatte
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently it is possible to gain information about directories even if
append_index_html_on_directories = false.This is caused by the mechanism to redirect to trailing slash for directories (like testcase
redirect_to_trailing_slash_on_dir()).This way, an attacker could search for directories by testing URLs without trailing slash and then could continue the
search within such a subdirectory using the same mechanism.
Solution
This pull request prevents the redirect and directly returns
404 Not Foundifappend_index_html_on_directories = false.