Adapt w.r.t. coq/coq#19931. #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! CI seems broken because of the stdlib split. I do not have time to fix or try the change locally it so I'll just merge it. |
We used to have a copy of the machine but it wasn't self-contained enough and ended up annoying Coq developers. I don't know that a from-scratch implementation that does not have this problem would really be a good idea and I don't think anybody has time to work on that. Either way, Mtac2 is seeing basically no development these days and I fear development and maintenance will be completely frozen at some point in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The part to break sharing voluntarily is a bit hackish, but it seems to work. I'd personally recommend reimplementing the CClosure machine locally rather than trying to piggyback on the one of Coq and relying on hidden internal behaviours, which may change abruptly. YMMV though.
This should be backwards compatible.