remove libmythupnp Rtti and merge remnants of libmythservicecontracts into mythfrontend #1044
Conversation
|
@ulmus-scott I did a quick test of mythfrontend without this pull request and it did shut down successfully after I ran one service (http://localhost:6551/Frontend/GetActionList). Is there a special condition under which it does not shut down, or are you saying that this pull request causes it to not shut down? |
|
@bennettpeter This pull request should not effect anything on port 6551. To prevent proper shutdown:
Without accessing port 6551, the next log message occurs after about 1 second and "Exiting" about 2 seconds after that. The terminal then presents the command prompt. |
|
From my post to mythtv-dev: The use of any of the pages on port 6551 cause mythfrontend to hang indefinitely when closing. It waits indefinitely somewhere in called frommythtv/mythtv/libs/libmythupnp/httpserver.cpp Line 176 in 0475f03 from |
|
There was a similar problem of not shutting down because of a thread not terminated in mythbackend a couple of years ago. Somebody, I think maybe Stuart, fixed it. |
|
I fixed the shutdown issue in #1066. The presentation in master has changed slightly since I removed gContext: the GUI is freezes/the screen doesn't update on alt-tab or changing back from a different virtual desktop since the window is now destroyed after the UPnP threads are shut down. |
Using std::chrono::microseconds directly is clearer and reduces transitive includes of libmythupnp/upnputil.h.
git grep -n GetEnum matches only a commented out line in mythtv/html/tv/schedule.qsp I believe this was for the WebFrontend using Qt Script, but never used. It appears to be originally Rtti::GetEnumDetails() from MythTV@cfcaf15 Became GetEnum() in MythTV@ad4c105 Current commented out use from MythTV@4d7f98a
@bennettpeter Rtti was unused, but the mythfrontend stuff still works (except that using port 6551 prevents mythfrontend from shutting down).
Checklist