Remove unnecessary 8000 includes of <ctime> #1142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only fwrite() is used.
The only user in MythTV code of gmtime_r() and localtime_r() is mythtv/libs/libmythtv/recorders/dvbdev/dvbci.cpp, which uses a Linux kernel driver, so will not compile on Windows, and does not include compat.h anyways.
Since std::chrono::seconds::rep is an integer type of at least 35 bits, it is almost certainly a long long.
These files use time_t. C++20 with <format> could replace these uses with std::chrono:system_clock, which is specified as Unix time starting in C++20.
mythzmserver/zmserver.h: has unused time_t members in unions, but does not directly include <ctime> (via <chrono> probably). mytharchivehelper/external/pxsup2dast.c: uses time_t and time() from <time.h>. libmythtv/recorders/dvbdev/dvbci.cpp: uses time_t, time(), struct tm, gmtime_r(), and localtime_r() via <ctime>. A few files in libmythtv/mpeg use time_t from <ctime>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most uses had already been replaced.
For
libmythtv/mpeg, I would prefer to use C++20 for gps_clock and utc_clock to replace time_t.Checklist