8000 Accounting for power to drive recirculation in heat exchangers by ngomezve · Pull Request #161 · MIT-LAE/TASOPT.jl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Accounting for power to drive recirculation in heat exchangers #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Accounting for power to drive recirculation in heat exchangers #161

wants to merge 19 commits into from

Conversation

ngomezve
Copy link
Contributor
@ngomezve ngomezve commented Apr 29, 2025 •
8000 edited
Loading

This PR adds a simple model to be used in engine-integrated heat exchangers (HEXs) that require recirculation. To drive the recirculating flow, some power input is needed. This is modeled as the power for isentropic compression of a compressible gas from the HEX outlet pressure to the HEX inlet pressure. This power is then added to the power offtakes in the engine.

The PR also addresses issue #173. It simplifies the data structure for the HEX data storage by using the dedicated engine.heat_exchangers object rather than relying on par arrays.

The PR also adds a few more features.

  • The tube wall temperature for the heat exchangers is now different on the cold and hot sides.
  • The HEX maximum length is an input; before it was hardcoded.
  • Brings back a 99% limit on effectiveness compared to the maximum possible one. This prevents errors if the effectiveness is lower than possible in some iteration.

@ngomezve ngomezve added the enhancement New feature or request label Apr 29, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.62044% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.63%. Comparing base (467abed) to head (b8e2f9b).

Files with missing lines Patch % Lines
src/engine/hxfun.jl 94.11% 5 Missing ⚠️
src/engine/ducted_fan/ductedfanweight.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   79.60%   79.63%   +0.02%     
==========================================
  Files 
8000
         91       91              
  Lines       14133    14168      +35     
==========================================
+ Hits        11251    11283      +32     
- Misses       2882     2885       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ngomezve ngomezve marked this pull request as ready for review May 19, 2025 15:49
@ngomezve ngomezve marked this pull request as draft May 27, 2025 14:58
@ngomezve ngomezve changed the title Accounting for power to drive recirculation in heat exchangers Accounting for power to drive flow in heat exchangers May 28, 2025
@ngomezve ngomezve changed the title Accounting for power to drive flow in heat exchangers Accounting for power to drive recirculation in heat exchangers May 28, 2025
@ngomezve ngomezve force-pushed the dev_recircpower branch 2 times, most recently from 0dff1bc to 6ca8702 Compare May 28, 2025 17:23
@ngomezve ngomezve marked this pull request as ready for review June 11, 2025 18:37
@ngomezve ngomezve requested a review from aditeyashukla June 12, 2025 17:56
@ngomezve
limiting maximum effectiveness
7a33429 
simpler limit

better comms
@ngomezve ngomezve force-pushed the dev_recircpower branch 2 times, most recently from 7fd51f7 to f74fee5 Compare June 16, 2025 19:14
@ngomezve
using engine.heat_exchangers to store HX data
3876957 
fixed tests

removed HX min wall T

fixed docstring

Update hxfun.jl
@ngomezve ngomezve requested a review from argonaut22 June 17, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditeyashukla aditeyashukla Awaiting requested review from aditeyashukla

@argonaut22 argonaut22 Awaiting requested review from argonaut22

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ngomezve
0