8000 Feature/better saving by nathanhhughes · Pull Request #86 · MIT-SPARK/Hydra · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Feature/better saving #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Feature/better saving #86

wants to merge 8 commits into from

Conversation

nathanhhughes
Copy link
Collaborator

Par 8000 t 2 of updating how everything from Hydra gets saved. Notes:

  • I'm trying to avoid writing out to files incrementally / avoiding requiring an output path when everything starts up. I might need to go update PGMO to also do this. This isn't to say we can't do incremental logging anywhere in the code but more that "saving" the current state of Hydra should be "atomic" and repeatable
  • I decided I liked the khronos style of dumping all the timing information to a single directory, so I got rid of the other version
  • I took the opportunity to clean up some unused configuration options in GlobalInfo
  • I also took the opportunity to clean up the timer functionality a little

I have branches going in most downstream repos / versions (including the ROS1 Hydra-ROS) that I'm working on finishing up and testing, wanted to get this out first for feedback so I don't have to do too much switching back and forth between ros1 and ros2

@Aryan-Naveen added you as a reviewer for situational awareness (feel free to browse if you have interest and/or time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoldenZephyr GoldenZephyr Awaiting requested review from GoldenZephyr

@yunzc yunzc Awaiting requested review from yunzc

@marcusabate marcusabate Awaiting requested review from marcusabate

@Schmluk Schmluk Awaiting requested review from Schmluk

@Aryan-Naveen Aryan-Naveen Awaiting requested review from Aryan-Naveen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nathanhhughes
0