ros2 build and warnings fixes. #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Wake <macwake@gmail.com>
This is similar to the mechanism used by kiss-icp Signed-off-by: Mike Wake <macwake@gmail.com>
Signed-off-by: Mike Wake <macwake@gmail.com>
Add required pcl headers Take colorize function from quatro_utils.h Add roll_aug_angle Avoid segfault on ubuntu22.04 by just calling spin() on pcl viewer Signed-off-by: Mike Wake <macwake@gmail.com>
Compared with NANOFLANN_VERSION 0x170 Signed-off-by: Mike Wake <macwake@gmail.com>
Signed-off-by: Mike Wake <macwake@gmail.com>
Signed-off-by: Mike Wake <macwake@gmail.com>
|
Whoa, Mike, really appreciate it, and that's what I needed! But now, I'm trying to submit a paper to ICCV, so could you give me a week? I'll check the codes this Sunday. Thanks! |
Signed-off-by: Mike Wake <macwake@gmail.com>
When use_ratio_test is true, need more space allocated to accomodate for it. Also avoid invalid read by testing ji != -1 before attempting to use it in i_to_j_multi_flann Signed-off-by: Mike Wake <macwake@gmail.com>
Signed-off-by: Mike Wake <macwake@gmail.com>
…D_OPERATOR_NEW address sanitizer is currently giving allocation alignment errors. Using c++17 to attempt to avoid them but there appears to be a mix of built libraries mixing eigen alignment preventing address sanitzer from working Signed-off-by: Mike Wake <macwake@gmail.com>
Keep default of CMAKE_BUILD_TYPE=Release but allow it to be overriden for debugging purposes Signed-off-by: Mike Wake <macwake@gmail.com>
Signed-off-by: Mike Wake <macwake@gmail.com>
|
Here are some more fixes. Its now valgrind and address sanitizer clean with a stress test to solve #30 |
|
I tested your codes, and they work without errors. Thanks for your kind attention and contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be
2C82
applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was exploring and decided to help fix some warnings. I note that newer versions of nanoflann fix the templates so that you can better choose the type that is used to store indexes. I changed it from size_t to uint32_t in this pull request. That may save some memory.
I also got brought run_kiss_matcher.cpp into kiss_matcher_ros.
Some of these changes may be useful to you.
I tried to keep them isolated and logical.