Check superclas 8000 s for property persistence #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A subclass can shadow a parent's property declaration, either explicitly with a `@property` directive or implicitly by conforming to a protocol that requires a particular property. The result is that the subclass property record has no associated ivar (or methods), and calls to get / set the property will fall up to the superclass's methods (backed by the superclass's ivar).
| if ([self isEqual:MTLModel.class]) { | ||
| return MTLPropertyStorageNone; | ||
| } else { | ||
| // Check superclass in case the subclass redeclares a property that falls through |
There was a problem hiding this comment.
Can you break this comment at 80 chars? I.e.
// Check superclass in case the subclass redeclares a property that
// falls through?
|
Thanks for your pull request 💖 I have just some minor notes. Also, can you merge in |
7dd6829 to
0747420
Compare
|
@robb Updated 🆕 |
|
Looks great, thanks again! |
robb
added a commit
that referenced
this pull request
Jul 31, 2015
Check superclass for property persistence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subclass can shadow a parent's property declaration, either explicitly
with a
@propertydirective or implicitly by conforming to a protocolthat requires a particular property. The result is that the subclass
property record has no associated ivar (or methods), and calls to get /
set the property will fall up to the superclass's methods (backed by the
superclass's ivar).