8000 fixes libextobjc header collision when using libextobjc by RonanLB · Pull Request #623 · Mantle/Mantle · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fixes libextobjc 8000 header collision when using libextobjc #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2015
Merged

fixes libextobjc header collision when using libextobjc #623

merged 1 commit into from
Oct 14, 2015

Conversation

RonanLB
Copy link
@RonanLB RonanLB commented Oct 14, 2015

this pull request relates to the issue reported here:
#610 (comment)

Mantle's version of libextobjc would conflict with another libextobjc dependency import while using pods.

In order to maintain Mantle 1.x working with the new cocoapods 0.38+ and version 7.x+ of xcode, those Mantle specific files have been renamed by adding to their name the "MTL" prefix

@RonanLB RonanLB mentioned this pull request Oct 14, 2015
Merged
@robb
Copy link
Member
robb commented Oct 14, 2015

LGTM

robb added a commit that referenced this pull request Oct 14, 2015
@robb
Merge pull request #623 from RonanLB/maintenance_1.5.x
e41221e 
fixes libextobjc header collision when using libextobjc
@robb robb merged commit e41221e into Mantle:1.x-maintenance Oct 14, 2015
@RonanLB
Copy link
Author
RonanLB commented Oct 15, 2015

@robb would it be possible to tag the changeset to 1.5.6 ?

@robb
Copy link
Member
robb commented Oct 15, 2015

Whoops, forgot about that one.

@dcaunt Can you work your cocoapods magic when you get a moment? 🙇

@dcaunt
Copy link
Member
dcaunt commented Oct 15, 2015

I've pushed 1.5.6 – should be live shortly

@RonanLB
Copy link
Author
RonanLB commented Oct 15, 2015

Thanks @dcaunt

@priteshshah1983
Copy link
Contributor

Thanks guys! Really appreciate all the work!

@yangtaoNewGame
Copy link

my project must be 7.0+ . you update to 2.x ，my project can not use 2.x. oh ,my god.

@yangtaoNewGame
< 8000 div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-152118755">
Copy link

version 1.5.6 ,can my project use it ?.

@dcaunt
Copy link
Member
dcaunt commented Oct 29, 2015

Yes, you can use 1.5.6.

@yangtaoNewGame
Copy link

hi dcaunt , in stackoverflow. http://stackoverflow.com/questions/32632280/how-to-build-mantle-v2-for-ios-7-0 , say " if you still want to user Mantle,either include its files into you project manully or use Cocoapods to build it as a static library using one of existing cocoapods spec file for mantle ". is it true??

@dcaunt
Copy link
Member
dcaunt commented Oct 30, 2015

That's correct. Installation via CocoaPods is not officially supported but the code itself should work all the way back to iOS 5.0.

6025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RonanLB @robb @dcaunt @priteshshah1983 @yangtaoNewGame
0