8000 Log VCS error output as debug messages by atombender · Pull Request #533 · Masterminds/glide · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Log VCS error output as debug messages #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2016
Merged

Log VCS error output as debug messages #533

merged 1 commit into from
Aug 2, 2016

Conversation

atombender
Copy link
Contributor

Enables logging of VCS error output when --debug is enabled.

I don't know if this is the ideal design — to be sure, the VCS error isn't ideal, and there's no central error reporting mechanism other than msg, which is why I extract the error there.

If I were to improve this, it'd be to encapsulate "some program failed to run and this is its failure info" as an error interface.

But I was fed up with getting unhelpful error messages ("Unable to get repository") from Glide, and this fixes that.

@mattfarina mattfarina merged commit beaa519 into Masterminds:master Aug 2, 2016
@mattfarina
Copy link
Member

Thanks for your contribution.

I understand your frustration. Thanks for helping to make it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atombender @mattfarina
0