8000 [Issue] [0.50.05] Unit Sale Price Generally Incorrect · Issue #6835 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Issue] [0.50.05] Unit Sale Price Generally Incorrect #6835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 tasks done
savanik opened this issue Apr 30, 2025 · 3 comments
Closed
5 tasks done

[Issue] [0.50.05] Unit Sale Price Generally Incorrect #6835

savanik opened this issue Apr 30, 2025 · 3 comments
Labels
Bug Severity: Low Issues described as low severity as per the new issue form

Comments

@savanik
Copy link
Contributor
savanik commented Apr 30, 2025

Brief Description *

There seems to be something going on with part / quality / unit pricing for vehicles. I am using default settings, option to reverse quality names is NOT checked.

Started up a new campaign. Purchased a Skulker Wheeled Scout Tank (base model) from the Unit Market. List price: List Price, 188,100, on purchase, sale price dropped to 8,125. Quality shows as F (best).

Using GM Mode, setting the quality to A changed the price to 5,000. Setting it back to F changed price to 8,125. Using 'Restore Unit' changed quality to D and changed price to 6,250.

Assigning it a crew (changing the condition from 'Crippled' to 'Undamaged' did not change the sale price. Assigning it a mechanic didn't change it. Advancing the month also did nothing.

This seems to be unique to ground vehicles - aerospace fighters and mechs seem to retain much, much more of their value (40% for quality A, 65% for quality F). I am assuming this is because there is some 'base price' for the chassis, and the 'parts' are the only thing being affected by the quality modifier.

3. Steps to Reproduce

  1. Start a new campaign with default settings.
  2. Purchase a ground vehicle from the Unit Market or from Purchase Unit. Observe sale price in Hangar.
  3. Use GM mode to adjust quality and observe changes in prices.

Attach Files

No response

Severity *

Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.

MekHQ Suite Version *

0.50.05

Operating System *

Linux (Debian)

Java Version *

OpenJDK Runtime Environment (build 17.0.14+7-Debian-1deb12u1)

Final Verification

  • I confirm this is a single, unique issue that hasn't been reported before
  • I have filled and provided all necessary information above
  • I have included any and all logs, custom units, and CPNX (save) files
  • I have asked on MegaMek Discord about this issue
  • I have confirmed this issue is being opened on the correct repository: MegaMek, MegaMekLab, or MekHQ
@savanik
Copy link
Contributor Author
savanik commented Apr 30, 2025

Additionally, unit prices seem generally low. A Seydlitz SYD-Z2, purchased at quality A and using GM Mode to bring it up to quality F, still only has a sale value of 754,468, where it sells new for 1,480,380. I would think that if parts should be selling at 0.65 multiplier, an F quality unit should not be valued around 51% of base price.

@savanik savanik changed the title [Issue] [0.50.05] Unit Sale Price for Ground Vehicles Incorrect [Issue] [0.50.05] Unit Sale Price Generally Incorrect Apr 30, 2025
@Scoppio Scoppio added Severity: Low Issues described as low severity as per the new issue form Bug labels May 1, 2025
@savanik
Copy link
Contributor Author
savanik commented May 3, 2025

Tracked this back to two problems.

  • Tank.java getPriceMultiplier had values that were incorrect
  • TankLocation.java had no values in getTonnage or getStickerPrice for returning cost for internal structure, controls, etc.

@savanik
Copy link
Contributor Author
savanik commented May 5, 2025

Fixed in pull request, merged into code.

@savanik savanik closed this as completed May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Severity: Low Issues described as low severity as per the new issue form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@savanik @Scoppio
0