8000 MIG-121 - Formatted error message on overwriting published template, set template status to draft unless a flag is set in cli by imaimai86 · Pull Request #401 · Medable/mdctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MIG-121 - Formatted error message on overwriting published template, set template status to draft unless a flag is set in cli #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 10, 2022
Merged

MIG-121 - Formatted error message on overwriting published template, set template status to draft unless a flag is set in cli #401

merged 4 commits into from
Nov 10, 2022

Conversation

imaimai86
Copy link
Contributor
@imaimai86 imaimai86 commented Oct 10, 2022 •
edited
Loading

Changes:

  • Modified error message on re-migration error to match
    • Template [templateName] ([key]) already exists in the target org and is not in DRAFT status, re-migration is not allowed.

re-migration-error

  • Update template status to draft while importing, unless the cli flag --preserveTemplateStatus is set

Screen Shot 2022-10-21 at 1 45 32 AM

@imaimai86 imaimai86 force-pushed the task/MIG-121 branch 3 times, most recently from 76cf3f3 to 3371c61 Compare October 11, 2022 07:32
@imaimai86 imaimai86 changed the base branch from master to develop October 17, 2022 12:22
@imaimai86 imaimai86 requested a review from joejean October 17, 2022 12:39
joejean
joejean previously approved these changes Oct 17, 2022
View reviewed changes
@joejean joejean mentioned this pull request Oct 17, 2022
Closed
@imaimai86 imaimai86 changed the title MIG-121 - Formatted error messge on ovwerwriting published template MIG-121 - Formatted error message on overwriting published template Oct 18, 2022
@imaimai86 imaimai86 changed the title MIG-121 - Formatted error message on overwriting published template MIG-121 - Formatted error message on overwriting published template, set template status to draft unless a flag is set in cli Oct 20, 2022
@imaimai86 imaimai86 requested a review from joejean October 20, 2022 21:47
@imaimai86 imaimai86 force-pushed the task/MIG-121 branch 3 times, most recently from 87bd7e3 to 200d309 Compare October 21, 2022 13:19
@joejean
Copy link
Collaborator
joejean commented Oct 21, 2022

LGTM

abulseed
abulseed approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor
@abulseed abulseed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideaquaro
Copy link
Contributor

Hi @imaimai86 , @joejean

If I'm not mistaken the version bump needs to be done in release/1.0.68 branch (which needs to be created from develop branch), as opposed to directly into develop branch.

Can you please double check with Gaston / Fiachra?

Thank you

@joejean joejean changed the base branch from develop to release/1.0.68 November 10, 2022 11:53
@joejean joejean merged commit af10e33 into release/1.0.68 Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joejean joejean joejean approved these changes

@abulseed abulseed abulseed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imaimai86 @joejean @davideaquaro @abulseed
0