10000 Remove deprecated stream-to-iter by disordered · Pull Request #408 · Medable/mdctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove deprecated stream-to-iter #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and t 8000 he community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2022
Merged

Remove deprecated stream-to-iter #408

merged 1 commit into from
Nov 14, 2022

Conversation

disordered
Copy link
Contributor

stream-to-iter functionality has been included since version 10 of node. Removing this dependency will remove bad engine warning during installation:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'stream-to-iterator@3.0.3',
npm WARN EBADENGINE   required: { node: '>=8.9 <10' },
npm WARN EBADENGINE   current: { node: 'v16.18.1', npm: '8.19.2' }
npm WARN EBADENGINE }

@disordered disordered changed the base branch from master to release/1.0.68 November 14, 2022 17:05
@disordered
Remove deprecated stream-to-iter
2344f70 
`stream-to-iter` functionality has been included since version 10 of node.
Removing this dependency will remove bad engine warning during installation:
```
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'stream-to-iterator@3.0.3',
npm WARN EBADENGINE   required: { node: '>=8.9 <10' },
npm WARN EBADENGINE   current: { node: 'v16.18.1', npm: '8.19.2' }
npm WARN EBADENGINE }
```
@disordered disordered force-pushed the remove-stream-to-iter branch from d567f3d to 2344f70 Compare November 14, 2022 17:07
@gastonrobledo gastonrobledo merged commit 8c9ace5 into Medable:release/1.0.68 Nov 14, 2022
@disordered disordered deleted the remove-stream-to-iter branch November 14, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonrobledo gastonrobledo gastonrobledo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@disordered @gastonrobledo
0