8000 Task/mig 148 remapping templates partial migrations by davideaquaro · Pull Request #409 · Medable/mdctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Task/mig 148 remapping templates partial migrations #409

New issue

Have a question about this project? S 8000 ign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2022
Merged

Task/mig 148 remapping templates partial migrations #409

merged 2 commits into from
Nov 21, 2022

Conversation

davideaquaro
Copy link
Contributor

Implemented requirements as per MIG-148
When conducting an eConsent Template migration to a new org, ID remapping must occur. This feature was implemented already as part of MIG-126, however it works only when performing a full study export, so we need to make sure the remapping occurs also when performing the following commands:

  • mdctl study export --manifestObject
  • mdctl study consent

The main changes are:

  • mdctl-axon-tools/lib/mappings/index.js: added a function that returns a mapping used when running mdctl study consent and moved the script template into its own function
  • mdctl-axon-tools/lib/mappings/maps/index.js: declared the function as per previous bullet point
  • mdctl-axon-tools/lib/mappings/map/EcBuilderDataMap.js: removed double quotes and adjusted code as per ESLint feedback
  • mdctl-axon-tools/lib/StudyManifestTools.js: added code to include the remapping script when performing a partial migration or a eConsent export
  • mdctl-axon-tools/tests/MIG-136/MIG-136.test.js: fixed unit tests
  • mdctl-axon-tools/tests/MIG-148/MIG-148.test.js: added new unit tests

meziane-medable
meziane-medable approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor
@meziane-medable meziane-medable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideaquaro davideaquaro merged commit 87f5f17 into release/1.0.68 Nov 21, 2022
@davideaquaro davideaquaro deleted the task/MIG-148-remapping-templates-partial-migrations branch November 21, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meziane-medable meziane-medable meziane-medable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davideaquaro @meziane-medable
0