MIG-105: Removed the work around function #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahueld
reviewed
May 13, 2022
| @@ -147,7 +147,7 @@ class StudyManifestTools { | |||
| this.writeIssues(removedEntities) | |||
| this.writePackage('study', extraConfig) | |||
|
|
|||
| return { manifest, removedEntities } | |||
| return { manifest, removedEntities, mappingScript } | |||
There was a problem hiding this comment.
hi Sharad, this is unrelated to MIG-105, this is already addressed in Davide's PR
This ticket is about removing the workaround in MenuConfigMapping class
There was a problem hiding this comment.
Also I'd like to understand why we get package-lock.json changes, can you confirm these are expected changes?
nahueld
approved these changes
May 17, 2022
| @@ -147,7 +147,7 @@ class StudyManifestTools { | |||
| this.writeIssues(removedEntities) | |||
| this.writePackage('study', extraConfig) | |||
|
|
|||
| return { manifest, removedEntities } | |||
| return { manifest, removedEntities, mappingScript } | |||
There was a problem hiding this comment.
Also I'd like to understand why we get package-lock.json changes, can you confirm these are expected changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, i removed the Work around function