fixed MIG-127 and adjusted tests to include manifest in memo #388
Conversation
There was a problem hiding this comment.
Hi @emilyackermanmedable,I think that property variable is used to determine if querying by 'c_study' (for full migrations) or 'c_key' (for partial migrations) when calling getObjectIDsArray method.
If that value is hard coded , will it still work properly for partial migrations where we pass c_key instances instead?
| @@ -707,7 +707,7 @@ class StudyManifestTools { | |||
| } | |||
| case 'ec__document_template': { | |||
| // Get the eConsents ID's from the study or the manifest | |||
| ids = (await this.getObjectIDsArray(org, key, property, values)).map(v => v._id) | |||
| ids = (await this.getObjectIDsArray(org, key, 'ec__study', values)).map(v => v._id) | |||
There was a problem hiding this comment.
Hi @emilyackermanmedable,I think that property variable is used to determine if querying by 'c_study' (for full migrations) or 'c_key' (for partial migrations) when calling getObjectIDsArray method.
If that value is hard coded , will it still work properly for partial migrations where we pass c_key instances instead?
There was a problem hiding this comment.
Fixed it - thank you for catching that!
Also fixed a bug in StudyManifestTools that previously meant ec__document_templates were not being included in study exports: we had been looking for the property "c_study" in ec__document_templates, but that property does not exist; rather, it is called ec__study on that object