8000 remove bundledDependencies. by nicks · Pull Request #603 · Medium/phantomjs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jul 24, 2019. It is now read-only.

remove bundledDependencies. #603

Merged
merged 1 commit into from
Aug 12, 2016
Merged

remove bundledDependencies. #603

merged 1 commit into from
Aug 12, 2016

Conversation

nicks
Copy link
Contributor
@nicks nicks commented Aug 12, 2016

Hello @nicks,

Please review the following commits I made in branch 'nicks/bundling'.

076b959 (2016-08-12 08:34:40 -0400)
remove bundledDependencies.
This option appears to be non-portable: a package published on one OS / NPM version
with bundledDependencies breaks in cryptic ways on other OSes and NPM versions.

R=@nicks

This option appears to be non-portable: a package published on one OS / NPM version
with bundledDependencies breaks in cryptic ways on other OSes and NPM versions.
@nicks nicks merged commit 2dead42 into master Aug 12, 2016
@nicks nicks deleted the nicks/bundling branch August 12, 2016 12:42
@NicolasPelletier
Copy link

This appears to have re-opened closed issues. See #607.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0