-
Notifications
You must be signed in to change notification settings - Fork 70
Support custom PROJ datum shifts #1051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am having serious issue with the builds from this PR: 1- Create a gpkg with EPSG:27700 Tested on Android 10. |
probably related to qgis/QGIS#40482 |
@PeterPetrik not really. There is no background layer. Just a single gpkg layer: |
1c6e4ac
to
285e469
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for personal explanation. I have some notes, but other than that, it looks good!
- there are several
qDebugs
instead of inputUtils::log please check if they are intended (more than just the one I pointed at) - developer documentation needs to be updated that we now need two new variables defined in config
- documentation on help.inputapp.io could tell that the easiest solution with proj is to upload them to Mergin together with project. So far it guides users to copy proj files manually to device, however It will be harder to copy files to android devices when we will target Android 11 due to a scoped storage.
And also changes need to be merged to QGIS before merging this PR |
302b125
to
3d29293
Compare
Change: we copy all custom proj files to specified folder on Input startup. So if the project contains a custom proj files, application needs to be restarted for them to be properly loaded. Changed manual test & docs accordingly |
Description of the PROJ initialization and workflow is in inutprojutils.h file