8000 Support custom PROJ datum shifts by PeterPetrik · Pull Request #1051 · MerginMaps/mobile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support custom PROJ datum shifts #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Feb 1, 2021
Merged

Support custom PROJ datum shifts #1051

merged 23 commits into from
Feb 1, 2021

Conversation

PeterPetrik
Copy link
Contributor
@PeterPetrik PeterPetrik commented Dec 4, 2020

Description of the PROJ initialization and workflow is in inutprojutils.h file

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

@PeterPetrik PeterPetrik requested a review from wonder-sk December 4, 2020 18:17
@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

@saberraz
Copy link
Contributor
saberraz commented Dec 7, 2020

I am having serious issue with the builds from this PR:

1- Create a gpkg with EPSG:27700
2- Save the project and try to load it in Input
3- Crash

Tested on Android 10.

@PeterPetrik
Copy link
Contributor Author

I am having serious issue with the builds from this PR:

1- Create a gpkg with EPSG:27700
2- Save the project and try to load it in Input
3- Crash

Tested on Android 10.

probably related to qgis/QGIS#40482

@saberraz
Copy link
Contributor
saberraz commented Dec 7, 2020

@PeterPetrik not really. There is no background layer. Just a single gpkg layer:
https://public.cloudmergin.com/projects/saber/proj_issue/tree

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

@PeterPetrik PeterPetrik changed the title Proj fixes support custom PROJ datum shifts Dec 16, 2020
@PeterPetrik PeterPetrik added enhancement FROZEN 🥶 do not merge before upcoming release labels Dec 16, 2020
@PeterPetrik PeterPetrik removed FROZEN 🥶 do not merge before upcoming release enhancement labels Dec 18, 2020
@PeterPetrik PeterPetrik added the squash squash before merging label Jan 6, 2021
@inputapp-bot
Copy link
Collaborator

win-apk: x86_64 (SDK: win-10)

Copy link
Collaborator
@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for personal explanation. I have some notes, but other than that, it looks good!

  • there are several qDebugs instead of inputUtils::log please check if they are intended (more than just the one I pointed at)
  • developer documentation needs to be updated that we now need two new variables defined in config
  • documentation on help.inputapp.io could tell that the easiest solution with proj is to upload them to Mergin together with project. So far it guides users to copy proj files manually to device, however It will be harder to copy files to android devices when we will target Android 11 due to a scoped storage.

@tomasMizera
Copy link
Collaborator

And also changes need to be merged to QGIS before merging this PR

@PeterPetrik PeterPetrik changed the title support custom PROJ datum shifts WIP 9E88 : support custom PROJ datum shifts Jan 27, 2021
@PeterPetrik PeterPetrik changed the title WIP: support custom PROJ datum shifts Support custom PROJ datum shifts Jan 27, 2021
@PeterPetrik
Copy link
Contributor Author

Change: we copy all custom proj files to specified folder on Input startup. So if the project contains a custom proj files, application needs to be restarted for them to be properly loaded. Changed manual test & docs accordingly

@PeterPetrik PeterPetrik merged commit 0836cac into master Feb 1, 2021
@PeterPetrik PeterPetrik deleted the proj_fixes branch February 1, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash squash before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0