Refactor Recording Layers Logic and Rename LayersProxyModel to RecordingLayersProxyModel #3761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14447401159Details
💛 - Coveralls |
4a0fcd5 to
9ae886d
Compare
uclaros
reviewed
Mar 28, 2025
10000
There was a problem hiding this comment.
Nice!
One more note:
ActiveProject::updateMapSettingsLayers() is always called right after ActiveProject::updateActiveLayer().
If ActiveProject::updateMapSettingsLayers() was always called first instead, then ActiveProject::updateActiveLayer() could avoid calling getVisibleLayers() once more and could just fetch the list of visible layers stored in settings (during ActiveProject::updateMapSettingsLayers())
Would that make sense?
uclaros
approved these changes
Mar 28, 2025
tomasMizera
requested changes
Apr 7, 2025
tomasMizera
requested changes
Apr 14, 2025
tomasMizera
approved these changes
Apr 14, 2025
harminius
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
Tested as suggested: 🟢 :
- Behavior on closing and reopening the app, preferably multiple times
- Behavior on switching projects and adding features of different layer geometry type between switches
- Behavior on adding multiple features across different layers and observing the "Choose Active Layer" panel
- Switching between multiple layers on the "Choose Active Layer" panel
- Ensuring tracking layer is not present on "Choose Active Layer," and performing the tests on both types of projects (with and without position tracking layer)
I once managed to record to the tracking layer manually (which should not be possible) -see empty field on the screenshot, but I cannot replicate that 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refinement on recording layers handling by:
LayersProxyModeltoRecordingLayersProxyModelQgsProjectfromRecordingLayersProxyModelfilterFunctionin favor of usingsetFiltersandexceptedLayerIdsrecordingAllowedfromInputUtilstoActiveProjectActive Project:getVisibleLayers()andpositionTrackingLayerId()LayerVisible) inLayersModelto support visibility filtering