8000 Key Factors P1 by hlbmtc · Pull Request #1466 · Metaculus/metaculus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Key Factors P1 #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Nov 28, 2024
Merged

Key Factors P1 #1466

merged 18 commits into from
Nov 28, 2024

Conversation

hlbmtc
Copy link
Contributor
@hlbmtc hlbmtc commented Nov 20, 2024 •
edited
Loading

Key Factors P1 implementation:

  • Implemented Key Factor models
  • Key factor admin interfaces
  • Key factor services
  • Updated Post services to include related key factors
  • Updated Comment services to include related key factors
  • Added key factor voting system
  • Implemented FE part of Key-Factors
  • Refactored comment anchors mechanism

Figma mocks -- https://www.figma.com/design/1zMpkkR1SyqKe7Hc4wR7cV/Key-Factors?node-id=48-10292&node-type=section&t=W9cbWfHuLMH9EBba-0
Notion doc -- https://www.notion.so/metaculus/Key-factors-12a6aaf4f10180b3bda2e26f8eb0d5cd

closes #1463

8000
@hlbmtc
Merge branch 'main' into feat/1463-key-factors-p1
37d272e 
# Conflicts:
#	comments/admin.py
@hlbmtc hlbmtc marked this pull request as ready for review November 27, 2024 17:41
ncarazon
ncarazon approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor
@ncarazon ncarazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

front_end/src/app/(main)/questions/[id]/components/key_factors.tsx
@@ -0,0 +1,57 @@
"use client";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes sense to mark this component as client component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but it throws an error:

  × You're importing a component that needs useState. It only works in a Client Component but none of its parents are marked with "use client", so they're Server Components by default.
  │ Learn more: https://nextjs.org/docs/getting-started/react-essentials

elisescu
elisescu approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor
@elisescu elisescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlbmtc hlbmtc merged commit 983e01b into main Nov 28, 2024
2 checks passed
@hlbmtc hlbmtc deleted the feat/1463-key-factors-p1 branch November 28, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisescu elisescu elisescu approved these changes

@ncarazon ncarazon ncarazon approved these changes

@lsabor lsabor Awaiting requested review from lsabor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Key Factors P1
3 participants
@hlbmtc @elisescu @ncarazon
0