frontend: remove unused dependencies #1504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this has been unused since 875cd15
the dep was added in 65d8344 but never actually used
added in 3f7c841 but never actually used
added in 56e1a61 but never used
unused since c3aeabb
it's still used indirectly, but package-lock can pin that just fine removing it from package.json helps prevent people from accidentally usiing it rather than fetch
unused since dc71f1f
unused since 4fd7185
|
also resolves GHSA-c7qv-q95q-8v27 (though the app wasn't actually vulnerable because the dependency is unused, and it's a bit of a fake "high" sev imo) |
hlbmtc
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why?
eliminating unused dependencies with prejudice is beneficial for a few reasons:
how?
I checked with depheck and then manually double checked that any reported package wasn't (a) used in the build (depcheck won't see that); (b) added recently as something that could be WIP (e.g.
sharp); (c) grepped around to double-sanity-check for any usage; (d) used git pickaxe (git log -S) to understand the historical context of the prior usage, if any.See commit messages for package-specific commentary.