Fix and Improve CI 🦾 #234
Merged
Fix and Improve CI 🦾 #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new GitHub Actions setup is still failing for release builds, and was lacking Carthage verification. ## Change - Remove .framework.zip asset (and respective Carthage build) from Release workflow (isn't used by anyone, AFAIK). - Remove explicit `ref` from release jobs' checkout steps - Unify `ci`, `pod-lint` and `spm` workflows into `ci.yml`, making it easier to maintain. - Add carthage verification job to `ci.yml`. - Add new `./scripts/carthage.sh` to work around Xcode 12 issues when running Carthage.
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 97 97
Lines 3296 3296
=======================================
Hits 3131 3131
Misses 165 165 Continue to review full report at Codecov.
|
diogoeiras
approved these changes
May 11, 2021
JOCuendet
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
The new GitHub Actions setup still had some issues on the
Releaseworkflow:the
workflow_runtriggers whenever one of the dependencies run, and we want it to run when all completejobs'
ifconditions were incorrect, so they always ranthe jobs should use the current git ref and not the head branch.
carthage build was broken, and probably isn't necessary to release a
.framework.zipanyway people should simply use their dependency manager of choice.The CI was also lacking Carthage verification.
Description
Fix
Releaseworkflow issues:Remove .framework.zip asset (and respective Carthage build) from Release workflow (isn't used by anyone, AFAIK).
Fix job
ifconditions.Remove explicit
reffrom git checkout steps.Unify
ci,pod-lintandspmworkflows intoci.yml, making it a single dependency forreleasewhile being easier to maintain.Add carthage verification job to
ci.yml.Add new
./scripts/carthage.shto work around Xcode 12 issues when running Carthage.