8000 feat: add license validation by koxudaxi · Pull Request #127 · Mirascope/lilypad · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add license validation #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 31, 2025
Merged

feat: add license validation #127

merged 11 commits into from
Jan 31, 2025

Conversation

koxudaxi
Copy link
Collaborator

No description provided.

Copy link
gitguardian bot commented Jan 30, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15392148 Triggered Generic CLI Secret 5ca86fa lilypad/ee/generate_free_tier_license.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@koxudaxi koxudaxi requested review from brenkao and willbakst January 30, 2025 15:17
Copy link
Collaborator
@brenkao brenkao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after comment resolved

Copy link
cloudflare-workers-and-pages bot commented Jan 31, 2025

Deploying lilypad-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2f78b97
Status: ✅  Deploy successful!
Preview URL: https://f5c27d83.lilypad-website-et1.pages.dev
Branch Preview URL: https://add-license-validation.lilypad-website-et1.pages.dev

View logs

@koxudaxi koxudaxi requested a review from brenkao January 31, 2025 00:55
@koxudaxi
Copy link
Collaborator Author

I can't merge the PR. GitGuardian Security Checks failed :(

@willbakst
Copy link
Contributor

I can't merge the PR. GitGuardian Security Checks failed :(

Looks like you'll need to update the documentation that seemingly uses an API key, perhaps use $YOUR_API_KEY or something to avoid the check?

@koxudaxi koxudaxi force-pushed the add-license-validation branch from 6b00fc5 to 2f78b97 Compare January 31, 2025 02:21
@koxudaxi koxudaxi merged commit 78c60af into main Jan 31, 2025
16 checks passed
@koxudaxi koxudaxi deleted the add-license-validation branch January 31, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0