do not reject promise on request returning error status #2934

Hugo-Trentesaux · 2019-02-11T18:44:08Z

Hugo-Trentesaux
Feb 11, 2019

Description

The current behaviour of the promise is the following :

when no extract function is provided, a 400 status code will lead to promise rejection
when an extract function is provided, a 400 status code will lead to promise resolution

This behaviour seems counter-intuitive. I think it should be changed.

I did a pull request to do what I thought would be the more obvious, but @isiahmeadows told me the reason it was like this : implemented in #2006 to comply with #2000

Because these reasons seems reasonable, I think we should align the behaviour of the function when no extract function is provided. That means:

if an error status code is returned, this will lead to promise resolution in any case (extract function provided or not)
promise rejection will only occur if an error is thrown (unexpected behavior)

Implementation

https://github.com/MithrilJS/mithril.js/blob/master/request/request.js#L115-L138

try {
	var response = xhr.responseText
	if (typeof args.extract === "function") {
		response = args.extract(xhr, args)
	} else if (typeof args.deserialize === "function") {
		response = args.deserialize(response)
	} else {
		try {response = response ? JSON.parse(response) : null}
		catch (e) {throw new Error("Invalid JSON: " + response)}
	}
	resolve(response)
}
catch (e) {
	reject(e)
}

Hugo-Trentesaux · 2019-02-11T21:30:41Z

Hugo-Trentesaux
Feb 11, 2019
Author

If it's valid and no error is raised, it goes through the extract function and then the resolution function.

0 replies

dead-claudia · 2019-02-11T21:18:00Z

dead-claudia
Feb 11, 2019
Maintainer

What if the error response is a JSON payload (as it usually is)?

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

do not reject promise on request returning error status #2934

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 2 comments

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Uh oh!

do not reject promise on request returning error status #2934

Uh oh!

Uh oh!

Hugo-Trentesaux Feb 11, 2019

Description

Implementation

Replies: 2 comments

Uh oh!

Hugo-Trentesaux Feb 11, 2019 Author

Uh oh!

dead-claudia Feb 11, 2019 Maintainer

Hugo-Trentesaux
Feb 11, 2019

Hugo-Trentesaux
Feb 11, 2019
Author

dead-claudia
Feb 11, 2019
Maintainer