Fixes CI #667
Merged
Fixes CI #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying to split up Carthage validation onto Travis, so they can run in parallel and save build time. We'll see! |
ashfurrow
commented
Sep 22, 2016
| fail("next called for invalid data") | ||
| case .failed(let error): | ||
| case .failure(let error): | ||
| receivedError = error |
There was a problem hiding this comment.
Do these changes make sense to you, @justinmakaila? I don't want to do something non-idiomatic to ReactiveSwift.
This reverts commit 15e1c0b.
|
Nah, never mind. Travis is having outages, might be worth reconsidering separately, but not now. |
|
Danger failing again, gotta learn not to force-push to PRs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #665. Also excludes the Demo app from our code coverage report.