8000 Elementimprovements by kylepokorski · Pull Request #166 · Nv7-GitHub/Nv7Haven · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Elementimprovements #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Elementimprovements #166

wants to merge 14 commits into from

Conversation

kylepokorski
Copy link
Contributor

better version of #163
Currently:Adds variable IDs, suggestion result saving to "last" element, and making combination code use same getElementIDs function

@kylepokorski
Changing combination code
ab433d0 
Making combining use same getElementIds function as !ac does
Making getElementId call getElementIds
@kylepokorski
Adding Variable IDs
483f79a 
adding variable ids
@kylepokorski
"Last" element saved after poll passes
44f28b1 
it saves the voting result to the creator's combcache
@kylepokorski
hint and next slight modification
eb19783 
Fixing plural for singular
@kylepokorski
suggest by ID
1efc3ed 
Making suggesting by ID work
fixing 1 nonexistent element not being capitalized
@kylepokorski kylepokorski marked this pull request as draft February 13, 2025 02:59
@kylepokorski
Adding multiple *X
f1d83e3 
Adding multiple *X (ex: *4 Water, *4 Air results in Water+Water+Water+Water+Air+Air+Air+Air)
Creating function ApplyMultiplier to deal with multiplier (this made it possible to add this feature)
@kylepokorski
Adding {text},{raw}
3065e10 
Adding {text}, {raw} which make following a name and not an ID or multiplier
however {raw} is supposed to ignore separators too which is not implemented
@kylepokorski
Further improvements such as implementing {raw}
c220692 
Implementing {raw},making *N work with + as first element . Adding {name} as an alias of {text}. Adding {id} as alias of #
@kylepokorski
Merge branch 'Nv7-GitHub:main' into elementimprovements
d1a31f6
@kylepokorski kylepokorski marked this pull request as ready for review February 20, 2025 22:35
kylepokorski and others added 5 commits February 25, 2025 15:00
@kylepokorski
Merge branch 'Nv7-GitHub:main' into elementimprovements
9a4bb9f
@kylepokorski
Merge branch 'main' into elementimprovements
85344fd
@kylepokorski
fixing +[element]
1c0866f 
Making it so +[element] works
@kylepokorski
fixing numeric/variable ids triggering without prefix
ebb04af 
making numeric and variable ids only trigger with the prefix
adding random and randominv as aliases for rand and randinv respectively
@kylepokorski
Bug fixes
e451d1d 
making random work again
Making multiplier work with spaces (trimming spaces)
making +element case actually work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylepokorski
0