CallSite can hide single class type using AddCallSiteHiddenClassType #5313
Conversation
…ich types to ignore. Refactored the SkipAssembly method into a ShouldSkip method to take both Hidden assemblies and types into account. Refactored LookupAssemblyFromStackFrame method into a LookupAssembly method that takes a MethodBase for better performance, as both places that call it use the MethodBase that is retrieved at the top of the method. Added a HiddenTypeTest that tests the functionality.
|
Thanks for opening this pull request! |
|
Kudos, SonarCloud Quality Gate passed! |
|
Thank you for the pull-request. I propose moving the NLog.LogManager.Setup().SetupLogFactory(setup => setup.AddCallSiteHiddenAssembly(hideAssembly));
NLog.LogManager.Setup().SetupLogFactory(setup => setup.AddCallSiteHiddenClassType(hideClassType));If you could resolve the current merge-conflicts, and apply the suggested changes from #5484 then it can be merged for NLog v5.3 (Give you proper credits) Alternative then I can merge #5484, and manually merge this pull-request after manuall fixing merge-conflicts. |
|
|
Hooray your first pull request is merged! Thanks for the contribution! Looking for more? 👼 Please check the up-for-grabs issues - thanks! |
|
Thank you! Sorry I didn't get to your request above. Thank you so much for supporting the community! |
|
NLog v5.3.1 has been released, that allows you to hide specific class-type, instead of the entire assembly. Thanks again for the contribution. |
|
Thank you for your hard work! |
LogManager.Setup()-extension-method.Refactored the SkipAssembly method into a ShouldSkip method to take both Hidden assemblies and types into account. Refactored LookupAssemblyFromStackFrame method into a LookupAssembly method that takes a MethodBase for better performance, as both places that call it use the MethodBase that is retrieved at the top of the method.
Added a HiddenTypeTest that tests the functionality.