8000 Feature/integrate by KelsonDenton · Pull Request #13 · NM-TAFE/battleships · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature/integrate #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Feature/integrate #13

wants to merge 8 commits into from

Conversation

KelsonDenton
Copy link

Attempted to put board class into main for player to use.

@KelsonDenton
Copy link
Author

The validation still has a few bugs but my PyCharm is having trouble importing libraries for the program so I haven't actually run it to test it. I've modified some of the import statements to try to get around it but it hasn't worked. There's also a test class to test out functionality of the board class

@j222144
Copy link
j222144 commented Nov 25, 2020

The validation still has a few bugs but my PyCharm is having trouble importing libraries for the program so I haven't actually run it to test it. I've modified some of the import statements to try to get around it but it hasn't worked. There's also a test class to test out functionality of the board class

have you try installing the package that is listed inside of requirement inside server folder server --> requirement.txt in there you will see the list of package you need

@shlecturer
Copy link
Contributor

The validation still has a few bugs but my PyCharm is having trouble importing libraries for the program so I haven't actually run it to test it. I've modified some of the import statements to try to get around it but it hasn't worked. There's also a test class to test out functionality of the board class

have you try installing the package that is listed inside of requirement inside server folder server --> requirement.txt in there you will see the list of package you need

I added a requirements.txt to the reference client too. You could copy that into your own client folder.

@shlecturer
Copy link
Contributor

It would be nice to not change the reference implementation unless it really improves it. It shouldn't be changed to accommodate for your own client. :)

@KelsonDenton
Copy link
Author

Ooh right. So just create our own folder where we do all our own implementation in the clients directory?

@KelsonDenton
Copy link
Author

The validation still has a few bugs but my PyCharm is having trouble importing libraries for the program so I haven't actually run it to test it. I've modified some of the import statements to try to get around it but it hasn't worked. There's also a test class to test out functionality of the board class

have you try installing the package that is listed inside of requirement inside server folder server --> requirement.txt in there you will see the list of package you need

I added a requirements.txt to the reference client too. You could copy that into your own client folder.

Oh cool thanks I added that and installed all the packages. For some reason it won't recognize the log.py file to be imported into other files though. I tried renaming the path but that didn't really help.

@Sandyman
Copy link
Contributor

Ooh right. So just create our own folder where we do all our own implementation in the clients directory?

Yes. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KelsonDenton @j222144 @shlecturer @Sandyman
0