8000 Nyx cycle changes by mskinner5278 · Pull Request #314 · NSLS2/lsdc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Nyx cycle changes #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 14, 2023
Merged

Nyx cycle changes #314

merged 17 commits into from
Jul 14, 2023

Conversation

mskinner5278
Copy link
Collaborator

This pull request should be reviewed after PR 309.

JunAishima
JunAishima requested changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator
@JunAishima JunAishima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are generally a lot of hard-coded changes that cannot be brought into LSDC because they would change behavior and look for AMX/FMX. please change these areas to enable merging into the main LSDC codebase

@mskinner5278
Copy link
Collaborator Author

To summarize, any changes that look like they would directly interfere with AMX/FMX rastering will not remain because it is not going to be used for the MD2 rastering code. We will likely split the rastering code into a different function to make the call with exporter. Those changes were never ever intended to be brought into master, and were not written to be.

@mskinner5278 mskinner5278 changed the base branch from 2023-2-nyx to 2023-2-amxfmx July 13, 2023 14:06
@mskinner5278 mskinner5278 changed the base branch from 2023-2-amxfmx to master July 13, 2023 14:06
@mskinner5278 mskinner5278 changed the base branch from master to 2023-2-nyx July 13, 2023 14:07
@mskinner5278 mskinner5278 marked this pull request as ready for review July 13, 2023 14:47
@JunAishima JunAishima requested review from tacaswell and vshekar July 13, 2023 14:47
@JunAishima
Copy link
Collaborator

we have agreed that to expedite the code review process, NYX-specific changes that are will affect AMX/FMX LSDC will be handled following the full approve of NYX for proprietary users.

tacaswell
tacaswell reviewed Jul 13, 2023
View reviewed changes
tacaswell
tacaswell reviewed Jul 13, 2023
View reviewed changes
tacaswell
tacaswell reviewed Jul 13, 2023
View reviewed changes
tacaswell
tacaswell reviewed Jul 13, 2023
View reviewed changes
@tacaswell
Copy link
Contributor

None of this looks like it has any impact on data security?

JunAishima
JunAishima reviewed Jul 13, 2023
View reviewed changes
Copy link
Collaborator
@JunAishima JunAishima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment about data security and writing of images for loop_center_xrec()

@JunAishima
Copy link
Collaborator

None of this looks like it has any impact on data security?

Please see my comment just below yours - there seems to be only one place where data security could be an issue within this pull request. The comment refers to a new function used to write out images and is implicitly using the current working directory instead of explicitly using the visitDirectory

@JunAishima JunAishima self-requested a review July 13, 2023 15:44
@JunAishima
Copy link
Collaborator

@mskinner5278 do you think you have addressed all of the issues with the pull request that have been brought up?

@mskinner5278
Copy link
Collaborator Author

@mskinner5278 do you think you have addressed all of the issues with the pull request that have been brought up?

Yep, let me know if you want more changes added.

tacaswell
tacaswell reviewed Jul 13, 2023
View reviewed changes
@mskinner5278 @tacaswell
Update daq_macros.py
5f38ddd 
Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
tacaswell
tacaswell approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor
@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this with reservations.

JunAishima
JunAishima approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator
@JunAishima JunAishima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am content that any data security issues have been resolved.

@JunAishima JunAishima merged commit de988e3 into NSLS2:2023-2-nyx Jul 14, 2023
mskinner5278 added a commit to mskinner5278/lsdc that referenced this pull request Feb 21, 2024
@mskinner5278
more changes based on NSLS2#314 review
de1c2e9
vshekar pushed a commit to vshekar/lsdc that referenced this pull request Jul 22, 2024
@mskinner5278 @vshekar
more changes based on NSLS2#314 review
786b75b
vshekar pushed a commit to vshekar/lsdc that referenced this pull request Oct 11, 2024
@mskinner5278 @vshekar
more changes based on NSLS2#314 review
eee6ad2
vshekar pushed a commit to vshekar/lsdc that referenced this pull request Oct 11, 2024
@mskinner5278 @vshekar
more changes based on NSLS2#314 review
6a3bcb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@JunAishima JunAishima JunAishima approved these changes

@vshekar vshekar Awaiting requested review from vshekar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mskinner5278 @JunAishima @tacaswell
0