8000 Fixed displaying puck name with proposal number by vshekar · Pull Request #339 · NSLS2/lsdc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed displaying puck name with proposal number #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fixed displaying puck name with proposal number #339

merged 2 commits into from
Oct 24, 2023

Conversation

vshekar
Copy link
Collaborator
@vshekar vshekar commented Oct 18, 2023

Added to master since faster-dewar-refresh is not in 2023-3-amxfmx

JunAishima
JunAishima reviewed Oct 20, 2023
View reviewed changes
Copy link
Collaborator
@JunAishima JunAishima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether I like this setting of the parentItem() by extending the string - seems like it may be prone to creating multiple strings added on, if there is a situation where, for whatever reason, this setting code is called after the puck name is already set.

do you see how situations where this extra adding-on might happen? if it is possible, can you think of a way to mitigate this issue?

@vshekar
Copy link
Collaborator Author
vshekar commented Oct 20, 2023 •
edited
Loading

The need for adding the pass number in such a way arises because proposal numbers are not associated with puck names, so we can only get the pass number in the loop that cycles through sample information.

Puck name is already set outside of this loop, the only thing left to do is add the pass information. The if parentItem.text().endswith() statement checks if the pass info is already added to the string, if it is, nothing more to do. I I guess instead of endswith() check I can replace it with if j = 0 to only add the string in the first iteration of the for loop, if you think that is more appropriate.

@JunAishima
Copy link
Collaborator
< 951E div class="edit-comment-hide">

looks like refreshTreeDewarView() is self-contained enough that you are reconstructing the name from scratch each time and should be safe enough.

@JunAishima JunAishima self-requested a review October 23, 2023 14:50
@vshekar vshekar merged commit f81b72d into NSLS2:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunAishima JunAishima JunAishima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vshekar @JunAishima
0