8000 fix: fix Ray typing to not use internal package by pcmoritz · Pull Request #537 · NVIDIA-NeMo/RL · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix Ray typing to not use internal package #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

fix: fix Ray typing to not use internal package #537

merged 1 commit into from
Jun 24, 2025

Conversation

pcmoritz
Copy link
Contributor
@pcmoritz pcmoritz commented Jun 23, 2025 •
edited
Loading

What does this PR do ?

Small fix to not use types from the private ray._raylet package and instead use them from the public ray package.

I also made fix upstream in Ray so the repr of the type show the correct ray.ObjectRef instead of the private version ray._raylet.ObjectRef (ray-project/ray#54011)

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

@pcmoritz
Fix Ray typing to not use internal package
3f53793 
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
@pcmoritz pcmoritz changed the title Fix Ray typing to not use internal package fix: fix Ray typing to not use internal package Jun 23, 2025
@terrykong terrykong enabled auto-merge June 24, 2025 05:58
@terrykong terrykong added this pull request to the merge queue Jun 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2025
@terrykong terrykong added this pull request to the merge queue Jun 24, 2025
@terrykong
Copy link
Contributor

requeueing, CI failed due to timeout since test time is right at the limit

Merged via the queue into NVIDIA-NeMo:main with commit 4a62fb6 Jun 24, 2025
18 of 20 checks passed
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jun 25, 2025
@pcmoritz @xxman-google
fix: fix Ray typing to not use internal package (NVIDIA-NeMo#537)
fa3d806 
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
Signed-off-by: Xuehan Xiong <xxman@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrykong terrykong terrykong approved these changes

@parthchadha parthchadha parthchadha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcmoritz @terrykong @parthchadha
0