feat: add flash-attn to core dependencies #545
+500
−452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Terry Kong <terryk@nvidia.com> fix Signed-off-by: Terry Kong <terryk@nvidia.com> fix setuptools Signed-off-by: Terry Kong <terryk@nvidia.com> bug Signed-off-by: Terry Kong <terryk@nvidia.com> unset variables to speed it up Signed-off-by: Terry Kong <terryk@nvidia.com> deal with flash-attn Signed-off-by: Terry Kong <terryk@nvidia.com> 2.8.0.post2 prebuilt wheels! Signed-off-by: Terry Kong <terryk@nvidia.com> Revert "2.8.0.post2 prebuilt wheels!" This reverts commit f945c50. Signed-off-by: Terry Kong <terryk@nvidia.com> revert Signed-off-by: Terry Kong <terryk@nvidia.com> uv.lock Signed-off-by: Terry Kong <terryk@nvidia.com> try wheel Signed-off-by: Terry Kong <terryk@nvidia.com> try whl Signed-off-by: Terry Kong <terryk@nvidia.com> comment Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
parthchadha
reviewed
Jun 27, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
parthchadha
approved these changes
Jun 27, 2025
Any commits made after this event will not be merged.
Any commits made after this event will not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that flash-attn has wheels for 2.7.0, users won't have to build flash-attn which require some manual steps like installing
ninjato ensure the build is not slow.Putting flash-attn in the base set of dependencies now means there's no initial step before the first "--no-build-isolation" call, so users have to now run
uv run pip install setuptoolsto make flash-attn happy.One other option is
uv venv --seed, but it sometimes doesn't reliably install setuptools, so we'll go with the pip install for now.