8000 fix: remove reference_model_buffers in fsdp2 by yuki-666 · Pull Request #558 · NVIDIA-NeMo/RL · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: remove reference_model_buffers in fsdp2 #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

fix: remove reference_model_buffers in fsdp2 #558

merged 1 commit into from
Jun 26, 2025

Conversation

yuki-666
Copy link
Contributor

What does this PR do ?

remove reference_model_buffers in fsdp2 to fix DeepSeek-V2-Lite's following error.

RuntimeError: The size of tensor a (512) must match the size of tensor b (163840) at non-singleton dimension 0

Test Result

DeepSeek-V2-Lite Llama-3.1-8B-Instruct
image image

@yuki-666
remove reference_model_buffers in fsdp2
cffb7e5 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-666 yuki-666 requested review from yfw and terrykong June 26, 2025 15:17
@yuki-666 yuki-666 added the CI:L1 Run doctests, unit tests, and functional tests label Jun 26, 2025
@terrykong terrykong enabled auto-merge June 26, 2025 16:32
@terrykong terrykong added CI:docs Run doctest and removed CI:L1 Run doctests, unit tests, and functional tests labels Jun 26, 2025
@terrykong terrykong added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit 0507318 Jun 26, 2025
26 of 32 checks passed
@terrykong terrykong deleted the yukih/deepseek-fsdp2 branch June 26, 8000 2025 19:22
parthchadha pushed a commit that referenced this pull request Jun 26, 2025
@yuki-666 @parthchadha
fix: remove reference_model_buffers in fsdp2 (#558)
6cd63ac 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jun 27, 2025
@yuki-666 @xxman-google
fix: remove reference_model_buffers in fsdp2 (NVIDIA-NeMo#558)
23614ec 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jun 27, 2025
@yuki-666 @xxman-google
fix: remove reference_model_buffers in fsdp2 (NVIDIA-NeMo#558)
9bef806 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfw yfw yfw approved these changes

@terrykong terrykong terrykong approved these changes

Assignees
No one assigned
Labels
CI:docs Run doctest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuki-666 @yfw @terrykong
0