10000 fix: Add assertion if async is disabled when using pp with vllm by parthchadha · Pull Request #565 · NVIDIA-NeMo/RL · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Add assertion if async is disabled when using pp with vllm #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

fix: Add assertion if async is disabled when using pp with vllm #565

merged 1 commit into from
Jun 26, 2025

Conversation

parthchadha
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@parthchadha
Add assertion if async is disabled when using pp with vllm
79ea9fd 
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
@parthchadha parthchadha marked this pull request as ready for review June 26, 2025 19:55
@parthchadha parthchadha requested a review from terrykong June 26, 2025 19:55
@terrykong terrykong added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit a70103b Jun 26, 2025
13 of 14 checks passed
@terrykong terrykong deleted the pchadha/vllm-async-error-improve branch June 26, 2025 22:31
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jun 27, 2025
@parthchadha @xxman-google
fix: Add assertion if async is disabled when using pp with vllm (NVID…
8b1451a 
…IA-NeMo#565)

Signed-off-by: Parth Chadha <pchadha@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jun 27, 2025
@parthchadha @xxman-google
fix: Add assertion if async is disabled when using pp with vllm (NVID…
b5bfda1 
…IA-NeMo#565)

Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrykong terrykong terrykong approved these changes

@SahilJain314 SahilJain314 SahilJain314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthchadha @terrykong @SahilJain314
0