8000 Use average reduction in FSDP grad reduce-scatter when grad dtype is … by erhoo82 · Pull Request #13981 · NVIDIA/NeMo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use average reduction in FSDP grad reduce-scatter when grad dtype is … #13981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use average reduction in FSDP grad reduce-scatter when grad dtype is … #13981

wants to merge 1 commit into from
+3 −1

Conversation

erhoo82
Copy link
Collaborator
@erhoo82 erhoo82 commented Jun 22, 2025

…BF16

What does this PR do ?

Use average gradient reduction when grad dtype is bf16

Changelog

  • Disable average reduction when grad dtype is fp32

Usage

  • Change of default setting

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@erhoo82
Use average reduction in FSDP grad reduce-scatter when grad dtype is …
61bb36e 
…BF16

Signed-off-by: Sangkug Lym <slym@nvidia.com>
@erhoo82 erhoo82 added RC3 r2.4.0 Pick this label for auto-cherry-picking into r2.4.0 Run CICD labels Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
r2.4.0 Pick this label for auto-cherry-picking into r2.4.0 RC3 Run CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erhoo82
0