test(content_safety): add tests for content safety actions #1240
+156
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a suite of tests for content safety actions to verify the tuple unpacking behavior introduced in #1207 and to validate proper error handling for missing or incorrect model parameters.
- New tests assert correct behavior for both tuple and single value results from content safety checks.
- Additional tests ensure that ValueErrors are raised when required model information is missing.
- Tests verify the logic of the content safety output mapping function.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1240 +/- ##
===========================================
+ Coverage 69.04% 69.34% +0.30%
===========================================
Files 161 161
Lines 15995 15995
===========================================
+ Hits 11043 11091 +48
+ Misses 4952 4904 -48
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
72d3e06 to
5249aa1
Compare
cparisien
approved these changes
Jun 26, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pouyan <13303554+Pouyanpi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for tuple unpacking implemented in #1207
Tests failing on develop branch prior to #1207:
https://github.com/NVIDIA/NeMo-Guardrails/actions/runs/15896264513/job/44828445306?pr=1240
Test pass after merging #1207:
https://github.com/NVIDIA/NeMo-Guardrails/actions/runs/15896746636?pr=1240