8000 fix: reset prefix cache when sleep is called to ensure prefix cache i… by parthchadha · Pull Request #112 · NVIDIA/NeMo-RL · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: reset prefix cache when sleep is called to ensure prefix cache i… #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2025
Merged

fix: reset prefix cache when sleep is called to ensure prefix cache i… #112

merged 5 commits into from
Apr 3, 2025

Conversation

parthchadha
Copy link
Collaborator
@parthchadha parthchadha commented Apr 1, 2025 •
edited by terrykong
Loading

…s not shared after weights are updated

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):
Closes #97

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@parthchadha
fix: reset prefix cache when sleep is called to ensure prefix cache i…
0c804df 
…s not shared after weights are updated

Signed-off-by: Parth Chadha <pchadha@nvidia.com>
@parthchadha
Copy link
Collaborator Author

Closes #97

@parthchadha parthchadha added the Run CICD Set to run CI (unset + set to rerun) label Apr 1, 2025
@SahilJain314
Copy link
Collaborator

Any way to test this?

@parthchadha parthchadha force-pushed the pchadha/reset-prefix-cache branch 2 times, most recently from e8da345 to 36a0574 Compare April 3, 2025 17:46
@parthchadha parthchadha added Run CICD Set to run CI (unset + set to rerun) and removed Run CICD Set to run CI (unset + set to rerun) labels Apr 3, 2025
@parthchadha parthchadha force-pushed the pchadha/reset-prefix-cache branch from 36a0574 to 4593b40 Compare April 3, 2025 18:58
terrykong
terrykong reviewed Apr 3, 2025
View reviewed changes
@parthchadha
Merge remote-tracking branch 'origin/main' into pchadha/reset-prefix-…
3a438bb 
…cache

Signed-off-by: Parth Chadha <pchadha@nvidia.com>
@parthchadha parthchadha force-pushed the pchadha/reset-prefix-cache branch from 4593b40 to 3a438bb Compare April 3, 2025 19:36
@parthchadha parthchadha added Run CICD Set to run CI (unset + set to rerun) and removed Run CICD Set to run CI (unset + set to rerun) labels Apr 3, 2025
terrykong
terrykong reviewed Apr 3, 2025
View reviewed changes
@parthchadha parthchadha enabled auto-merge (squash) April 3, 2025 20:04
@parthchadha parthchadha merged commit 535eaab into main Apr 3, 2025
11 checks passed
@parthchadha parthchadha deleted the pchadha/reset-prefix-cache branch April 3, 2025 20:05
KiddoZhu pushed a commit that referenced this pull request May 6, 2025
@parthchadha
fix: reset prefix cache when sleep is called to ensure prefix cache i… (
c4c6018 
#112)

Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrykong terrykong terrykong approved these changes

@SahilJain314 SahilJain314 Awaiting requested review from SahilJain314

Assignees
No one assigned
Labels
Run CICD Set to run CI (unset + set to rerun)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delete prefix cache upon refit
3 participants
@parthchadha @SahilJain314 @terrykong
0