8000 feat: SFT improvements: refactor and add validation and checkpointing by ashors1 · Pull Request #15 · NVIDIA/NeMo-RL · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: SFT improvements: refactor and add validation and checkpointing #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 21, 2025
Merged

feat: SFT improvements: refactor and add validation and checkpointing #15

merged 13 commits into from
Mar 21, 2025

Conversation

ashors1
Copy link
Collaborator
@ashors1 ashors1 commented Mar 21, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing

  • TBD

Additional Information

  • Related to # (issue)

ashors1 added 6 commits March 20, 2025 20:22
@ashors1
add validation and checkpointing to sft
e14aa12 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
cleanup, support different batch sizes for train and val
b8c7b20 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
cleanup
f8ba6fe 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
bug fixes
f91cbbb 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
Merge branch 'main' of github.com:NVIDIA/reinforcer into ashors/sft-ckpt
4c9b3ec
@ashors1
set more reasonable defaults for sft
93ff8ae 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 changed the title SFT improvements: refactor and add validation and checkpointing feat: SFT improvements: refactor and add validation and checkpointing Mar 21, 2025
ashors1 added 4 commits March 20, 2025 22:00
@ashors1
remove old todo
d5b769e 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
remove unused imports
fbd2b3f 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
fix copyright
4446b2b 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
fix issue sft ending one step early
3dd006a 
Signed-off-by: ashors1 <ashors@nvidia.com>
SahilJain314
SahilJain314 reviewed Mar 21, 2025
View reviewed changes
ashors1 added 2 commits March 21, 2025 00:15
@ashors1
address comments
3228b5e 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
single gpu default
cf943e2 
Signed-off-by: ashors1 <ashors@nvidia.com>
@SahilJain314 SahilJain314 enabled auto-merge (squash) March 21, 2025 07:35
@SahilJain314 SahilJain314 merged commit 759ac40 into main Mar 21, 2025
1 check passed
@SahilJain314 SahilJain314 deleted the ashors/sft-ckpt branch March 21, 2025 07:36
KiddoZhu pushed a commit that referenced this pull request May 6, 2025
@ashors1
feat: SFT improvements: refactor and add validation and checkpointing (…
0ce48aa 
…#15)

Signed-off-by: ashors1 <ashors@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SahilJain314 SahilJain314 SahilJain314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashors1 @SahilJain314
0