8000 fix: ray.sub race condition when overlapping srun commands on same node by terrykong · Pull Request #39 · NVIDIA/NeMo-RL · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: ray.sub race condition when overlapping srun commands on same node #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

fix: ray.sub race condition when overlapping srun commands on same node #39

merged 1 commit into from
Mar 24, 2025

Conversation

terrykong
Copy link
Collaborator

trying a different approach

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@terrykong
fix: ray.sub race condition when overlapping srun commands on same node
8000
dae4643 
trying a different approach

Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong merged commit 43ace69 into main Mar 24, 2025
5 checks passed
@terrykong terrykong deleted the slurm-race-condition branch March 24, 2025 19:06
@terrykong terrykong self-assigned this Mar 24, 2025
@terrykong terrykong added bug Something isn't working Infra Related to infrastructure labels Mar 24, 2025
@terrykong terrykong moved this to Done in NeMo RL v0.2 Mar 31, 2025
KiddoZhu pushed a commit that referenced this pull request May 6, 2025
@terrykong
fix: ray.sub race condition when overlapping srun commands on same no…
57d4be7 
…de (#39)

Signed-off-by: Terry Kong <terryk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SahilJain314 SahilJain314 SahilJain314 approved these changes

Assignees

@terrykong terrykong

Labels
bug Something isn't working Infra Related to infrastructure
Projects
NeMo RL v0.2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terrykong @SahilJain314
0