Refactor loading indicators to use consistent UI components #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced various Lucide Loader2 spinners with centralized LoadingIndicator and Spinner components Updated loading states in billing dashboard components (EditPlanServiceQuantityDialog, FixedPlanServicesList, PlanTypeRouter) Standardized loading indicators in UI components (EntityAvatar, EntityImageUpload) Improved ActivityDetailViewerDrawer loading state with new Spinner component Impacts: More consistent loading UI across the application Easier to modify loading indicators globally Reduced direct dependency on Lucide icons There's a couple that slipped through my thrift last time, but most spinners now dance to the same tune. 🎩♫🌀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced various Lucide Loader2 spinners with centralized LoadingIndicator and Spinner components Updated loading states in billing dashboard components (EditPlanServiceQuantityDialog, FixedPlanServicesList, PlanTypeRouter) Standardized loading indicators in UI components (EntityAvatar, EntityImageUpload) Improved ActivityDetailViewerDrawer loading state with new Spinner component Impacts:
More consistent loading UI across the application
Easier to modify loading indicators globally
Reduced direct dependency on Lucide icons
There's a couple that slipped through my thrift last time, but most spinners now dance to the same tune. 🎩♫🌀