buildMozillaMach: apple-sdk_14 -> apple-sdk_15 starting with version 138 #400163
Conversation
Apply overlay to fix darwin build until NixOS/nixpkgs#400163 lands
|
Ah, I see, it's for the upcoming version 138 (to become stable at the end of April): |
|
Please update the commit message accordingly. This is touching all firefox and thunderbird versions, and ESR 128 as well as DevEdition 138 needs to work with this change. |
|
Should this be scoped to latest versions only? Is it needed for Thunderbird? |
Really no reason to scope it for only one version if it builds fine for all. Haven't tested thunderbird. |
Meh... > error[E0599]: no method named `setAlignment_` found for struct `objc::StrongRef<NSMutableParagraphStyle>` in the current scope
> --> toolkit/crashreporter/client/app/src/ui/macos/mod.rs:1064:24
> |
> 1064 | ps.setAlignment_(cocoa::NSTextAlignmentRight);
> | ^^^^^^^^^^^^^
> |
> ::: toolkit/crashreporter/client/app/src/ui/macos/objc.rs:68:1 |
0:01.18 ERROR: SDK version "14.4" is too old. Please upgrade to at least 15.2. Try updating your system Xcode. Newer versions of firefox require apple-sdk_15.
|
Just changing it to version check for changing SDK, keeps rebuilds down for other versions and fixes new versions. |
|
Thunderbird 138 isn't even out upstream yet (we have 137 as default now), so who knows. |
|
any objections to getting this in so we can cache the devedition/beta builds? just had to rebuild again locally with a recent flake update |
0:01.18 ERROR: SDK version "14.4" is too old. Please upgrade to at least 15.2. Try updating your system Xcode.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.