cosmopolitan: 2.2 -> 4.0.2 #400333
Open
cosmopolitan: 2.2 -> 4.0.2 #400333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleksanaa
reviewed
Apr 20, 2025
| @@ -27,6 +28,18 @@ stdenv.mkDerivation (finalAttrs: { | |||
| }) | |||
| ]; | |||
|
|
|||
| cosmopolitan-cosmocc = fetchzip { | |||
| url = "https://github.com/jart/cosmopolitan/releases/download/${finalAttrs.version}/cosmocc-${finalAttrs.version}.zip"; | |||
There was a problem hiding this comment.
Is that this binary also runs on arm64... (if testing with qemu-user)? Then we can have aarch64 in our platforms
1b77ea4 to
de6b9ab
Compare
| postPatch = '' | ||
| sed -i '/^DOWNLOAD := $(shell build\/download-cosmocc.sh /d' Makefile | ||
| mkdir .cosmocc | ||
| ln -s ${cosmocc} .cosmocc/3.9.2 |
There was a problem hiding this comment.
So this is using the downloaded binary cosmocc to bootstrap, right? Nothing against that just clarifying
|
|
My build of this ran into: dbg
cosmopolitan> test/tool/net/lunix_test.lua:123: assertion failed!
cosmopolitan> redbean: test/tool/net/lunix_test.lua:161: UnixTest failed (o/tmp/o/tmp/lunix_test.54380)
cosmopolitan> stack traceback:
cosmopolitan> [C]: in function 'error'
cosmopolitan> test/tool/net/lunix_test.lua:161: in function 'main'
cosmopolitan> test/tool/net/lunix_test.lua:165: in main chunk
cosmopolitan>
cosmopolitan> `make MODE= -j12 o//test/tool/net/lunix_test.lua.runs` exited with 2:
cosmopolitan> o//tool/net/redbean -i test/tool/net/lunix_test.lua
cosmopolitan> consumed 256,502µs wall time
cosmopolitan> ballooned to 1,796kb in size
cosmopolitan> needed 4,888us cpu (42% kernel)
cosmopolitan> caused 449 page faults (96% memcpy)
cosmopolitan> 11 context switches (63% consensual)
cosmopolitan> performed 27 read and 0 write i/o operations
cosmopolitan>
cosmopolitan> make: *** [build/rules.mk:92: o//test/tool/net/lunix_test.lua.runs] Error 2 |
I don't know why, but I can't reproduce it. |
Also works on my end. Based on the code, I would hypothesize that this has something to do with filesystem block size. For me, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff: jart/cosmopolitan@2.2...4.0.2
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.