gz-math: init at 8.1.1 #401753
Open
gz-math: init at 8.1.1 #401753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethancedwards8
suggested changes
Apr 26, 2025
bengsparks
suggested changes
Apr 26, 2025
bengsparks
suggested changes
Apr 30, 2025
6361eb1 to
2b4c1e6
Compare
bengsparks
suggested changes
May 2, 2025
bengsparks
suggested changes
May 2, 2025
| gz-cmake | ||
| ]; | ||
|
|
||
| buildInputs = [ |
There was a problem hiding this comment.
The repository also supports generating Python bindings via pybind11, do you intend to support this?
There was a problem hiding this comment.
problem is, If I try calling pybind11, the following happens:
error:
… while calling the 'abort' builtin
at /nix/store/y4kpggqfiwxajb9ghffbbmhzdcmhrp46-source/lib/customisation.nix:312:7:
311| else
312| abort "lib.customisation.callPackageWith: ${error}";
| ^
313|
error: evaluation aborted with the following error message: 'lib.customisation.callPackageWith: Function called without required argument "pybind11" at /nix/store/y4kpggqfiwxajb9ghffbbmhzdcmhrp46-source/pkgs/by-name/gz/gz-math/package.nix:13'
bengsparks
suggested changes
May 3, 2025
| gtest, | ||
| python3, | ||
| ruby, | ||
| swig, |
|
|
||
| nativeBuildInputs = [ | ||
| cmake | ||
| gz-cmake |
There was a problem hiding this comment.
+ ] ++ lib.optional withPython (python3.withPackages (p: [ p.pybind11 ]));There was a problem hiding this comment.
Add a corresponding Python package that uses pkgs.gz-math with toPythonModule to create the module for you
| tag = "gz-math${lib.versions.major finalAttrs.version}_${finalAttrs.version}"; | ||
| hash = "sha256-E7u3EtpqNLvcqI5ycezwwAlbVHM3JdqeyLFWYlEaOYo="; | ||
| }; | ||
|
|
There was a problem hiding this comment.
+ postPatch =
+ # Remove vendored pybind11 and gtest, use nixpkgs' versions instead.
+ ''
+ rm -r src/python_pybind11
+ substituteInPlace src/CMakeLists.txt --replace-fail \
+ "add_subdirectory(python_pybind11)" "# add_subdirectory(python_pybind11
8244
)"
+
+ rm -r test/gtest_vendor
+ substituteInPlace test/CMakeLists.txt --replace-fail \
+ "add_subdirectory(gtest_vendor)" "# add_subdirectory(gtest_vendor)"
+ '';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.