8000 dvdisaster: fix build by thunze · Pull Request #403685 · NixOS/nixpkgs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

dvdisaster: fix build #403685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

dvdisaster: fix build #403685

merged 1 commit into from
May 2, 2025

Conversation

thunze
Copy link
Contributor
@thunze thunze commented May 2, 2025 •
edited
Loading
  • GCC 14 doesn't allow implicit function declarations.
  • Including stdio.h in the generated conftest.c fixes the build.

ZHF: #403336

GCC 14 tracking: #388196, #356812

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 2, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 2, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 403685

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/14800058895

x86_64-linux

✅ 2 packages built:
  • dvdisaster
  • dvdstyler

aarch64-linux

✅ 2 packages built:
  • dvdisaster
  • dvdstyler

@Sigmanificient Sigmanificient merged commit 461fc8e into NixOS:master May 2, 2025
33 checks passed
@thunze thunze deleted the fix-dvdisaster branch May 2, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thunze @Sigmanificient
0