8000 python3Package.parfive: build from source by sarahec · Pull Request #403720 · NixOS/nixpkgs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

python3Package.parfive: build from source #403720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

Conversation

sarahec
Copy link
Contributor
@sarahec sarahec commented May 2, 2025

Hydra build failure on Darwin due to use of local networking.

Changes:

  1. Enabled local networking on Darwin
  2. Switched to building from source
  3. Modernized the python build
  4. Made aioftp optional
  5. Fixed meta block
  6. Adopted

ZHF: #403336

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sarahec sarahec added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 2, 2025
< 8000 a class="d-inline-block" data-test-selector="pr-timeline-events-actor-avatar" data-hovercard-type="user" data-hovercard-url="/users/sarahec/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/sarahec">@sarahec sarahec force-pushed the pyfive-zhf branch from a45b836 to d549285 Compare May 2, 2025 19:24
@sarahec sarahec changed the title python3Package.pyfive: fixes python3Package.pyfive: build from source May 2, 2025
@sarahec sarahec added the 0.kind: package adoption Requests or PRs for adopting packages that have no maintainers label May 2, 2025
@sarahec sarahec changed the title python3Package.pyfive: build from source python3Package.parfive: build from source May 2, 2025
@sarahec
Copy link
Contributor Author
sarahec commented May 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 403720


x86_64-linux

✅ 4 packages built:
  • python312Packages.parfive
  • python312Packages.parfive.dist
  • python313Packages.parfive
  • python313Packages.parfive.dist

@sarahec
Copy link
Contributor Author
sarahec commented May 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 403720


aarch64-darwin

✅ 4 packages built:
  • python312Packages.parfive
  • python312Packages.parfive.dist
  • 8000 python313Packages.parfive
  • python313Packages.parfive.dist

@pbsds
Copy link
Member
pbsds commented May 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 403720


x86_64-linux

✅ 4 packages built:
  • python312Packages.parfive
  • python312Packages.parfive.dist
  • python313Packages.parfive
  • python313Packages.parfive.dist

aarch64-linux

✅ 4 packages built:
  • python312Packages.parfive
  • python312Packages.parfive.dist
  • python313Packages.parfive
  • python313Packages.parfive.dist

x86_64-darwin

✅ 4 packages built:
  • python312Packages.parfive
  • python312Packages.parfive.dist
  • python313Packages.parfive
  • python313Packages.parfive.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.parfive
  • python312Packages.parfive.dist
  • python313Packages.parfive
  • python313Packages.parfive.dist

@pbsds pbsds merged commit 1141c98 into NixOS:master May 2, 2025
32 checks passed
@sarahec sarahec deleted the pyfive-zhf branch May 2, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: package adoption Requests or PRs for adopting packages that have no maintainers 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0