8000 generic-updater: Add rev-suffix support by jtojnar · Pull Request #403218 · NixOS/nixpkgs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
10000

generic-updater: Add rev-suffix support #403218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

jtojnar
Copy link
Member
@jtojnar jtojnar commented May 1, 2025

Needed for ashpd-demo, which has tags ending with -demo: https://github.com/bilelmoussaoui/ashpd/releases

See 84ad3afd1186f9a9e78fdae9eff2566d76c4fe8f

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jtojnar jtojnar requested a review from romildo May 1, 2025 05:34
@github-actions github-actions bot added the 6.topic: updaters Tooling for (semi-)automated updating of packages label May 1, 2025
@jtojnar jtojnar added this to GNOME 48 May 1, 2025
@jtojnar jtojnar moved this to Ready in GNOME 48 May 1, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 1, 2025
Copy link
Contributor
@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtojnar jtojnar merged commit 9133c5d into NixOS:master May 6, 2025
29 checks passed
@jtojnar jtojnar deleted the update-rev-suffix branch May 6, 2025 21:01
@github-project-automation github-project-automation bot moved this from Ready to Done in GNOME 48 May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: updaters Tooling for (semi-)automated updating of packages 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants
0