8000 doom64ex-plus: init at 4.0.0.3.1 by keenanweaver · Pull Request #303690 · NixOS/nixpkgs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

doom64ex-plus: init at 4.0.0.3.1 #303690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

doom64ex-plus: init at 4.0.0.3.1 #303690

wants to merge 1 commit into from
+89 −0

Conversation

keenanweaver
Copy link
Member

Description of changes

Adds doom64ex-plus, closes #299262

Cannot test locally for darwin or aarch64.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@keenanweaver keenanweaver force-pushed the quake-stuff branch 2 times, most recently from ece9534 to 797c832 Compare April 13, 2024 12:52
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Apr 13, 2024
@keenanweaver
Copy link
Member Author

4.0.0.0 is out but it uses SDL3 which is not in nixpkgs yet.

@keenanweaver keenanweaver marked this pull request as draft November 12, 2024 12:44
@keenanweaver keenanweaver force-pushed the quake-stuff branch 2 times, most recently from 85e37bb to 37ed623 Compare November 12, 2024 13:22
@keenanweaver
Copy link
Member Author

Pending #326699

@keenanweaver keenanweaver changed the title doom64ex-plus: init at 3.6.5.9 doom64ex-plus: init at 4.0.0.3 Dec 2, 2024
@marcin-serwin
Copy link
Contributor

sdl3 has been merged. I've successfully built and ran it locally after rebasing onto master.

@keenanweaver
Copy link
Member Author

sdl3 has been merged. I've successfully built and ran it locally after rebasing onto master.

I was going to wait for the next release for these changes before reopening this back from draft. But I'm glad the package is working for someone else!

@keenanweaver keenanweaver changed the title doom64ex-plus: init at 4.0.0.3 doom64ex-plus: init at 0-unstable-2025-01-18 Mar 12, 2025
@keenanweaver keenanweaver marked this pull request as ready for review March 12, 2025 00:04
@keenanweaver
Copy link
Member Author

@marcin-serwin Instead of waiting for upstream, I think I'll just set this to review.

@github-actions github-actions bot added 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Mar 12, 2025
qubitnano
qubitnano approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor
@qubitnano qubitnano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 303690

x86_64-linux

✅ 1 package built:
  • doom64ex-plus

aarch64-linux

✅ 1 package built:
  • doom64ex-plus

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Mar 13, 2025
marcin-serwin
marcin-serwin suggested changes Mar 14, 2025
View reviewed changes
@marcin-serwin marcin-serwin mentioned this pull request Mar 15, 2025
Merged
13 tasks
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Mar 15, 2025
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Mar 15, 2025
@keenanweaver keenanweaver changed the title doom64ex-plus: init at 0-unstable-2025-01-18 doom64ex-plus: init at 4.0.0.3 Apr 26, 2025
@keenanweaver
Copy link
Member Author
keenanweaver commented Apr 26, 2025 •
edited
Loading

Upstream fixed the build, so I swapped to a tagged release and removed libGLU.

@marcin-serwin
Copy link
Contributor

swapped to a tagged release and removed libGLU.

I don't see any changes regarding libGLU in this release, it's still included on darwin.

@keenanweaver keenanweaver changed the title doom64ex-plus: init at 4.0.0.3 doom64ex-plus: init at 4.0.0.3.1 May 3, 2025
qubitnano
qubitnano approved these changes May 4, 2025
View reviewed changes
Copy link
Contributor
@qubitnano qubitnano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 303690

x86_64-linux

✅ 1 package built:
  • doom64ex-plus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcin-serwin marcin-serwin marcin-serwin approved these changes

@qubitnano qubitnano qubitnano approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: doom64ex-plus
4 participants
@keenanweaver @marcin-serwin @qubitnano @wegank
0